Prevent recursive PATH additions in sub-shell. #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasongin
reviewed
Mar 30, 2021
| @@ -226,10 +226,14 @@ fi | |||
| # If some version is linked as the default, begin by using that version. | |||
| if [ -d "${NVS_HOME}/default" ]; then | |||
| if [ -f "${NVS_HOME}/default/bin/node" ]; then | |||
| export PATH="${NVS_HOME}/default/bin:${PATH}" | |||
| if [[ ! "$PATH" == *"${NVS_HOME}/default/bin"* ]]; then | |||
There was a problem hiding this comment.
Unfortunately I don't think this syntax is compatible with all POSIX shells. This script file is not always executed via bash; it needs to be sourced directly from the user's preferred shell.
There was a problem hiding this comment.
I think for POSIX compatibility you need to use case.
There was a problem hiding this comment.
shebang desides the work of functionality, shellcheck will answer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix to prevent the PATH from growing in sub-shells.