Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect phantomjs in grunt reporter #12

Closed
wants to merge 1 commit into from
Closed

detect phantomjs in grunt reporter #12

wants to merge 1 commit into from

Conversation

tkellen
Copy link

@tkellen tkellen commented Aug 15, 2012

this is handy if you want to run your specs in a normal browser (since the fix for issue #4 seems to be inlining this script on your runner)

this is handy if you want to run your specs in a normal browser (since the fix for issue #4 seems to be inlining this script on your runner)
@tkellen tkellen closed this Aug 22, 2012
@creynders
Copy link
Member

Hi @tkellen I was just going to review this right now, but noticed you'd closed the pull request. Wasn't it working correctly?

@tkellen
Copy link
Author

tkellen commented Aug 24, 2012

Hey Camille!

I'm using this over on tkellen/requirejs-library-skeleton (and all the libraries I've built with the template). For whatever reason, the issue with the tests timing out (creynders/grunt-jasmine-task#4) resolved itself so it wasn't needed.

This is what I did, if you'd like to include it:

if(/phantom/i.test(navigator.userAgent)) {
    jasmine.getEnv().addReporter( new GruntReporter() );
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants