-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Functionality. #378
base: master
Are you sure you want to change the base?
New Functionality. #378
Conversation
…target directory.
* feature/images: add language types for jpg, jpeg, and png. # Conflicts: # resources/languages.json
Breaking changes: Defaults to hierarchical file write. output directory's directory structure will match the directory structure where the original files are located. -f --flatten overrides Theme jst files must change 'path.basename(destination(source))' to 'destination(source)' (todo: backward compatibility flag?) Markdown files show images on the right side of the page. (todo: add flag for backward compatibility) Optional .docco.json file can have glob based filename specifications: '**/*.coffee'. Parameter -s --setup for specifying a docco.json file. Copies .jpg, .jpeg, .png, and .tiff files if specified. TODO: drier code, variable file extensions in the target directory. breaking changes with flatten and themes
Merge branch 'master' into feature/refactor-file-locations * master: minor changes, this version doesn't link up non-flattened files # Conflicts: # docco.js.map
Holy crap! Do you have a link to an example of your new |
Here's an example: https://builddirect.github.io/deals-service/ It's very similar to the parallel layout, there are just changes to the menu structure right now. The intent was to have a three column format, but I don't have enough css mojo to be able to pull it off. So instead i just went with annotating the directory associated with the files in the dropdown menu. |
Can you talk a little about how you're supporting multiline comments? What did you have to change? |
To support multiline comments I added to the language.jason:
The parser code uses this to find the markers in the code. Since it goes line by line, the assumption is that when the marker is found, a flag is on to redirect the next lines to the docsText section until the stop marker is found. The manipulation of hasCode parallels the behaviour of normal docText, except the final save is not done, and there needs to be a switch back to the code finding with hasCode set to yes at the end. The assumption is that the parser is in a code section, so it needs to go back to code mode. |
no message
# Conflicts: # docco.js # docco.js.map # test/unit-tests/fakes/fake-config.js # test/unit-tests/fakes/fake-config.js.map
I hesitate to propose this pull request, but here it goes anyway. If you want to keep what you have, as is, I am happy to start down a new path and reference and be referenced by your work with docco. That said I am really happy if you decide the changes are valuable and incorporate them.
Added Functionality:
which means that in the parallel theme, images are displayed on the right
Refactors:
Possible Breaking Changes:
The question here is are there other templates that have been created and should a backward compatibility flag be added to proved the old behaviour?
This:
<a class="source" href="<%= path.basename(destination(source)) %>">
Can be changed to whatever is needed since links to all other files as well as other options are available:
Use --flatten to get the old behaviour
Should this flag be changed to something else with a default behaviour being flatten?
Anyway, that's a lot of features and changes.