Update gitignore template to add coverage #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
agilgur5
requested changes
Nov 7, 2020
There was a problem hiding this comment.
@mimshwright good find that the templates were missing this!
You've changed the basic template, but this change should also be added to the other two templates as well for consistency (and because they all use tsdx test / Jest) -- could you please add this change in those templates as well?
I've also requested a small change in-line that should go in all 3.
| @@ -2,3 +2,4 @@ | |||
| .DS_Store | |||
| node_modules | |||
| dist | |||
| coverage | |||
There was a problem hiding this comment.
Suggested change
| coverage | |
| # Jest test coverage reports | |
| coverage |
Could we add a comment here? I'm planning on adding comments to other portions of this file similar to #864
agilgur5
added
scope: templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #922