Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Setup #92

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Fix Setup #92

merged 2 commits into from
Feb 14, 2024

Conversation

mzouink
Copy link
Member

@mzouink mzouink commented Feb 14, 2024

No description provided.

@mzouink mzouink requested a review from cmalinmayor February 14, 2024 20:06
@cmalinmayor
Copy link
Contributor

noooo don't undo my beautiful changes!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9c68549) 65.74% compared to head (55a413a) 65.72%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
- Coverage   65.74%   65.72%   -0.02%     
==========================================
  Files         174      174              
  Lines        5202     5202              
==========================================
- Hits         3420     3419       -1     
- Misses       1782     1783       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mzouink
Copy link
Member Author

mzouink commented Feb 14, 2024

@cmalinmayor i brought back your change and set the old authors order to keep credits to Jan and Will as firsts

@mzouink mzouink merged commit 36748eb into main Feb 14, 2024
5 of 9 checks passed
@mzouink mzouink deleted the fix_setup branch February 14, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Release
Development

Successfully merging this pull request may close these issues.

3 participants