Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename TerminationReason::ErrorWaiting => InternalError #802

Merged

Conversation

michaelsilver
Copy link
Contributor

Renaming error status introduced in #799 so that it's more user friendly.

Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plane ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 8:17pm

Copy link
Member

@rolyatmax rolyatmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense - thanks!

@michaelsilver michaelsilver merged commit 03df75d into main Aug 13, 2024
4 of 5 checks passed
@michaelsilver michaelsilver deleted the michael/dis-2431-rename-errorwaiting-termination-status branch August 13, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants