Migrate off storing BackendName in Docker labels
#793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rolyatmax
approved these changes
Jul 24, 2024
paulgb
approved these changes
Jul 24, 2024
paulgb
requested changes
Jul 24, 2024
Instead of storing a label like: - "dev.plane.backend": "xjbgb03bhfxqgp" We will now store a label like: - "dev.plane.backend": "true" Critically, this allows us to continue relying on `"dev.plane.backend"` as an _identifier_ for plane backends, while deprecating the reliance on that label for carrying the `BackendName`. The only place we relied on the `BackendName` carried by this label was in the events loop, where as it turns out docker already applies a `"name"` attribute to events. Otherwise, introduce some helper functions to idiomatically convert between `ContainerId` and `BackendName`.
michaelsilver
force-pushed
the
michael/dis-2323-plane-migrate-off-using-docker-labels-to-identify-backends
branch
from
a34a08f to
3ce9c9d
Compare
paulgb
approved these changes
Jul 25, 2024
michaelsilver
deleted the
michael/dis-2323-plane-migrate-off-using-docker-labels-to-identify-backends
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of storing a label like:
"dev.plane.backend":"xjbgb03bhfxqgp"We will now store a label like:
"dev.plane.backend":"true"Critically, this allows us to continue relying on
"dev.plane.backend"as an identifier for plane backends, while deprecating the reliance on that label for carrying theBackendName.The only place we relied on the
BackendNamecarried by this label was in the events loop, where as it turns out docker already applies a"name"attribute to events.Otherwise, introduce some helper functions to idiomatically convert between
ContainerIdandBackendName.