Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sed extended REGEX in server manager config update #74

Closed
wants to merge 1 commit into from

Conversation

RobertRR
Copy link

some substitutions are failing.
Resolves multiple similar issues regarding env VAR substitutions.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this worked for me

@jammsen
Copy link
Owner

jammsen commented Jan 26, 2024

Hello @RobertRR - Can you describe your problem please more so i can try to reprouce and understand the problem better?

Examples would be nice, because i tried this yesterday to set everything 1.0000 to 2.0000 as an example and it worked.

Not trying to say anything mean here, just trying to understand whats the problem, please help me.

@jammsen jammsen added the issue-unclear Issue unclear label Jan 26, 2024
@RobertRR
Copy link
Author

Mostly issues like #66

jammsen added a commit that referenced this pull request Jan 26, 2024
@jammsen
Copy link
Owner

jammsen commented Jan 26, 2024

Hello @RobertRR - Thanks so much for the help in this.
Sadly i have a lot more to change then only this and did this on my develop branch to try if everything works first. Im sorry that i dont use this PR, but i cant add you manually as a contributor 😭

@jammsen jammsen added duplicate This issue or pull request already exists and removed issue-unclear Issue unclear labels Jan 26, 2024
@jammsen
Copy link
Owner

jammsen commented Jan 26, 2024

Closed in favor of #79
Again big thanks.

@jammsen jammsen closed this Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants