Configurable access credentials #682
Open
+92
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leontastic
force-pushed
the
feature/configurable-access-credentials
branch
2 times, most recently
from
8994fc4 to
2ac7a3a
Compare
kherock
reviewed
Feb 13, 2021
leontastic
force-pushed
the
feature/configurable-access-credentials
branch
4 times, most recently
from
2bbe402 to
4402072
Compare
leontastic
changed the title
|
Also want to add support for using I just documented the new config options in the cli options, but README instructions still needed. Also still needs tests proving |
…fusion with access keys
…r based on S3rver configuration
leontastic
force-pushed
the
feature/configurable-access-credentials
branch
from
e8019eb to
a2c3337
Compare
Codecov Report
@@ Coverage Diff @@
## main #682 +/- ##
==========================================
- Coverage 89.16% 88.82% -0.34%
==========================================
Files 20 20
Lines 1375 1387 +12
==========================================
+ Hits 1226 1232 +6
- Misses 149 155 +6
Continue to review full report at Codecov.
|
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs test cases proving
defaultAccessKeyIdanddefaultSecretAccessKeyand documentation in both CLI and README.