Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage reporting #600

Closed
wants to merge 1 commit into from
Closed

Conversation

kkoskelin
Copy link
Contributor

As an aid to ensuring proper coverage, I've installed istanbul and configured coverage numbers that ought to ensure the threshold reflects current coverage and do not slip below those given numbers.

------------------------------|---------|----------|---------|---------|----------------------------------------------------------------------------
File                          | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                                                          
------------------------------|---------|----------|---------|---------|----------------------------------------------------------------------------
All files                     |   88.38 |    76.48 |   90.87 |   88.78 |                                                                            
 lib                          |   84.76 |     51.3 |   93.33 |   84.23 |                                                                            
  routes.js                   |   78.05 |    34.83 |     100 |   77.78 | 24,38,74,79,107,112,122,151,156,168,170,184,189,200,202,213,222,227        
  s3rver.js                   |   82.64 |    65.96 |   88.24 |   82.35 | 70-72,99,111,116,122,152,153,175,191-194,196,233,237,247,253,259,260       
  utils.js                    |   96.97 |    94.44 |   93.75 |   96.67 | 65,85                                                                      
 lib/controllers              |   90.27 |    86.51 |     100 |   90.38 |                                                                            
  bucket.js                   |   90.43 |    87.84 |     100 |   91.15 | 146,157,171,184,199,206,285,290,376,380                                    
  object.js                   |   89.83 |    84.62 |     100 |   89.53 | 24,119,125,169,170,174,175,274,308,313,347,353,467,473,518,524,579,586     
  service.js                  |     100 |      100 |     100 |     100 |                                                                            
 lib/middleware               |   89.46 |    84.44 |   94.29 |   89.57 |                                                                            
  authentication.js           |    87.5 |    80.21 |     100 |   87.41 | 145,146,152,178,219,239,252,262,296,312,356,379,412,420,421,427,446        
  cors.js                     |   94.44 |    90.63 |     100 |   94.29 | 22,29                                                                      
  logger.js                   |     100 |      100 |     100 |     100 |                                                                            
  response-header-override.js |   95.65 |    92.31 |     100 |   95.45 | 35                                                                         
  vhost.js                    |     100 |      100 |     100 |     100 |                                                                            
  website.js                  |   86.24 |    82.35 |      75 |   86.79 | 16,24,49,50,174,178,188,194,200,201,239,242,247,249                        
 lib/models                   |   85.35 |    83.33 |   77.78 |   85.94 |                                                                            
  account.js                  |   81.82 |      100 |   66.67 |   81.82 | 16,17                                                                      
  bucket.js                   |     100 |      100 |     100 |     100 |                                                                            
  config.js                   |    78.3 |     81.2 |   73.91 |   79.21 | 28,38,49,65,74,142-144,146,157,167,180,181,187,188,204,216,224,238,245,351 
  error.js                    |   86.96 |    57.14 |      70 |   86.36 | 9,69,75                                                                    
  event.js                    |     100 |      100 |     100 |     100 |                                                                            
  object.js                   |     100 |      100 |     100 |     100 |                                                                            
  routing-rule.js             |   95.24 |    96.15 |     100 |   95.24 | 51                                                                         
 lib/stores                   |   91.36 |    73.49 |   90.57 |   93.69 |                                                                            
  filesystem.js               |   91.36 |    73.49 |   90.57 |   93.69 | 21,30,62,63,129,164,218,219,240,275,368,467,489                            
------------------------------|---------|----------|---------|---------|----------------------------------------------------------------------------

I would like to submit further pull requests with even more test coverage, and this would be a helpful tool.

@kherock
Copy link
Collaborator

kherock commented Jun 6, 2020

@kkoskelin thanks for putting this together, it's definitely needed. Those numbers are better than I was expecting!

@jamhall while I have your attention, could you install codecov to this repo when you have time? I don't think it needs additional setup for collaborator access, and open source licenses are free. Thanks!

@jamhall
Copy link
Owner

jamhall commented Jun 11, 2020

@kherock - I have activated codecov. Not too sure what I need to do now? I have a token... I guess you'll need this token once GH actions has been setup?

Copy link
Contributor

@fishcharlie fishcharlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are merge conflicts. But other than that, this looks like a great PR!

@fishcharlie
Copy link
Contributor

Codecov does have a GitHub action. I don't think that needs to be included in this PR and can be included in a separate PR once we get GitHub actions support up and running.

Base automatically changed from master to main February 12, 2021 14:09
@kherock
Copy link
Collaborator

kherock commented Feb 12, 2021

This is now in the main branch via #681, closing.

@kherock kherock closed this Feb 12, 2021
@kkoskelin kkoskelin deleted the add-coverage branch February 12, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants