Apply review comments

.github/workflows/javascript.yaml

@@ -16,7 +16,11 @@ jobs:
       uses: actions/setup-node@v1
       with:
         node-version: '${{ matrix.node }}'
-    - name: Build
-      run: make build
+    - name: Install
+      run: npm install
+    - name: Lint via prettier check 
+      run: npm run prettier-check
+    - name: Lint via eslint
+      run: npm run eslint
     - name: Test
-      run: make test
+      run: npm run test

Dockerfile

@@ -7,4 +7,3 @@ EXPOSE 8080
 VOLUME /data
 COPY . .
 CMD ["node","bin/s3rver.js", "-p", "8080", "-d", "/data"]
-

README.md

@@ -53,15 +53,15 @@ $ s3rver --help
 Build image
 
 ```bash
-$ make build_docker
+$ npm run docker:build
 ```
 
 You will now have a image `jamhall/s3rver:latest` available.
 
 Executing this command to start server:
 
 ```bash
-$ make start_docker
+$ npm run docker:start
 ```
 
 Server will listen on port `8080`.

package.json

@@ -28,7 +28,10 @@
     "test": "mocha",
     "eslint": "eslint --ignore-path .gitignore .",
     "prettier": "prettier --ignore-path .gitignore \"**/*.{js,json,md}\"",
-    "format": "npm run eslint -- --fix && npm run prettier -- --write"
+    "format": "npm run eslint -- --fix && npm run prettier -- --write",
+    "docker:build": "docker build -t jamhall/s3rver:latest .",
+    "docker:push":"docker build -t jamhall/s3rver:latest .",
+    "docker:start": "docker run -v $(pwd)/data:/data -p 8080:8080 jamhall/s3rver:latest"
   },
   "main": "lib/s3rver.js",
   "files": [