refactor: use aws sdk for signing packages #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jamesmbourne can this be released as an alpha channel release, so that we can test it, and to avoid reverts, like last time? |
|
Thanks for this @nguyentoanit! And good idea @moltar - this is available as https://www.npmjs.com/package/aws4-axios/v/3.0.0-alpha.1 |
|
any chance this can be relooked at? |
|
@nguyentoanit I don't remember what the issue was originally. But it looks like there is a CDK-based test suite available now, so maybe we can recover this PR and fix the issues? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #35