Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/473: TypeaheadSelector component #474

Merged
merged 21 commits into from
Jan 16, 2025
Merged

Conversation

rammohan-y
Copy link
Contributor

@rammohan-y rammohan-y commented Dec 26, 2024

#473

Created a new UI typeachead-selector component and used in application-select and account-select component

The features of the new component:
Key features:
- Input field with autocomplete functionality
- Dropdown toggle button with chevron icons
- Dropdown list of filterable options
- Keyboard navigation support
- Accessibility attributes (ARIA)

@xquanluu
Copy link
Contributor

Thanks @rammohan-y , could you please help to attach an image about that component here :) I need it to validate on my local run

@rammohan-y
Copy link
Contributor Author

rammohan-y commented Dec 26, 2024

Thanks @rammohan-y , could you please help to attach an image about that component here :) I need it to validate on my local run

image

@xquanluu the new component will be reflected across webapp where account selection and/or application selection is involved. From UI point of view it looks similar to the selector component. The above screenshot is from carriers screen

@vdharashive
Copy link

@xquanluu can you pls review it

@xquanluu
Copy link
Contributor

Hi @rammohan-y

Please check that font-size, font weight, and background, border is not aligned with orther component, could you make it more align as much as possible.
Screenshot 2024-12-31 at 11 55 08

Screenshot 2024-12-31 at 11 55 03

@xquanluu
Copy link
Contributor

For functionality which is working very nice, just fix the styling then we are good to go

@rammohan-y
Copy link
Contributor Author

rammohan-y commented Dec 31, 2024

For functionality which is working very nice, just fix the styling then we are good to go

@xquanluu i fixed styles issue, but i did not understand the border alignment, I am seeing that the border is properly aligned, can you please help me find the issue with border alignment

image

@davehorton
Copy link
Contributor

On the Recent Calls page, shouldn't the account dropdown by a typeahead? In my testing on jambonz.me it is not

@rammohan-y
Copy link
Contributor Author

On the Recent Calls page, shouldn't the account dropdown by a typeahead? In my testing on jambonz.me it is not

@davehorton the drop downs in recent calls are implemented with a set of components e.g. account dropdown is implemented using account-filter.tsx component, whose usage is different than the selector component. Hence its not implemented yet. We can look at how to use Typeahead for the AccountFilter component in near future?

@rammohan-y
Copy link
Contributor Author

On the Recent Calls page, shouldn't the account dropdown by a typeahead? In my testing on jambonz.me it is not

@davehorton the drop downs in recent calls are implemented with a set of components e.g. account dropdown is implemented using account-filter.tsx component, whose usage is different than the selector component. Hence its not implemented yet. We can look at how to use Typeahead for the AccountFilter component in near future?

@davehorton also the styles, dimensions of the filter components in recent-calls page are very different to the ones used in forms. We need another set of typeahead components for filter in recent calls

@rammohan-y
Copy link
Contributor Author

On the Recent Calls page, shouldn't the account dropdown by a typeahead? In my testing on jambonz.me it is not

@davehorton the account filter component is also converted to typeahead, and is deployed to jambonz.me, please verify

@davehorton davehorton merged commit db08bad into jambonz:main Jan 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants