Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/php8 #34

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix/php8 #34

wants to merge 5 commits into from

Conversation

wells
Copy link

@wells wells commented Mar 19, 2021

Primary changes:

  • Set php >=7.1 to allow for php 8.0
  • Crossgrade to php-parallel-lint/php-parallel-lint
  • Upgrade phpstan
  • Enable phpunit v9

Notes:

  • phpunit and lint are passing
  • phpstan has a lot of primarily "no return typehint specified," "no typehint specified," etc. errors

Do you want to ignore some of these static analysis errors?

@Tom32i
Copy link

Tom32i commented Jun 29, 2021

Is this ready? :)

@jspaetzel
Copy link

Could use a merge from master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wells @Tom32i @jspaetzel