Fix for #14 - Buffer events always and check buffer always after socket polling #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. Thank you for the PR! And sorry for such a delay :( I've looked through the code and it looks good, I've run current test suite and it passes. Could you add a regression test case, i.e. test that fails with the old version and gets fixed by this patch? |
|
Hi, you can checkout 96a5d5b to see the failing test for the DevtoolsClient. A problem that i see with the current solution, is that the buffer is not flushed. |
|
@jakubkulhan can the pull request be confirmed or any conflict from manual review pending? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.