Fix Multiple Player in one site #21 #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes for multiple players on one page.
Credit to adm351 for his CSS solution: jakiestfu#11 (comment)
Allows selection between the 'dark' (default) and the 'light' player themes available. Ref: https://developers.google.com/youtube/player_parameters#theme Will add support to change the list bar theme to match the light theme in a future commit.
Merging changed from a current project to this git, forgot to remove the extra position.
You can now select between 'light' and 'dark' themes for both the player and list separately using playerTheme and listTheme. Light theme may need to be tweaked in the future, sort of rough draft for the moment. Adjusted responsiveness to reflect bootstrap transitions as well as 1280px felt a bit high for the UI change.
Colour changes + fixed broken css.
- Documentation Updated with added features/settings - Moved responsiveness to ytv.js to add it as a setting - Added responsive.html to demo the new settings - Custom bootstrap.min.css for the purpose of demoing the responsiveness
Added missing = when adding video viewCount
Conflicts: README.md
Static value top = -10px, in responsive this was not needed.
More coffee required.
More coffee required.
git fetch coffee
git fetch coffee
Syncing gh-pages and master
Syncing up gh-pages and master.
- Todo all the things. - `local` variable to avoid `file://` error on localhost - multiplayer test/demo in prep for merge
Conflicts: src/ytv.js
Extra `id` tags to css to keep player settings separate. Note: playlist thumbnail returns null/hangs specifically for `collegehumor` will look into later as this may become an issue with certain account types. (Not an issue with any other accounts tested.)
Might be a rough start, but I'll throw it at the wall and see what sticks.
April 20th APIv2 cut off is approaching fast. -__- Time to kick it into high gear!
Fixed formatting + removed duplicates.
YTV-APIv2 + Coffee + EDM + More Coffee = YTV-APIv3
Youtube APIv3 ready! 👍
Updated reference doc.
- Documentation changes - APIv3 Key Help - Todo list moved to Todo.md (no issue tracker on forks 😢 )
…ed the first clip in the list starts. (optional setting)
* Added the ability for multiple playlists in `playlist: ''` option separated by comma's * Updated/Added more detail to Documentation * Fixed jQuery validation where `id` CSS modifications were required (credit to @zevero)
Add playid. Play the movie with this id in the playlist.
- Changed all spaces to tabs... because tabs. - Fixed some validation issues - Removed `loadAds` function - Trimmed trailing spaces and spacing Note: Experimenting with some Sublime plugins at this point to make life easier.
- Implemented a caching solution that should drastically reduce API usage! (This will help out any high traffic sites that may concerned about quota usage) - Sorting! Sort by upload date, reverse, and shuffle options! - Meaningful Error Messages, as well as passing through errors from the Youtube API into the console. - `playId` setting will now automatically scroll down the list to the video selected. - Removed support for ancient versions of IE (versions <IE6). Current IE support is IE9 for now, looking into IE8 issues.
Additional documentation as well as more clarification between `user` and `channelId`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for multiple players on one page.