[Feature Request] onCheck/onClick/onExpand returns object w/ same data provided at invocation #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flattenNodes returns an object with a new shape.
The goal here is to pass the caller of CheckboxTree -- onClick/onExpand/onCheck -- a
node w/ the same data passed to it at invocation
inside the nodes array.
We now return all properties of the object passed at invocation under the keyspace
"extraKeys": { ...node }
MaxwellKendall
changed the title
MaxwellKendall
commented
Apr 1, 2020
| 'disabled', | ||
| 'treeDepth', | ||
| 'index', | ||
| 'extraKeys', |
There was a problem hiding this comment.
I think we actually should remove this line. Wasn't able to test this locally. Was getting an error on npm run examples and npm run test had some tests that appeared to be failing for me on the master branch w/o my changes.
Suggested change
| 'extraKeys', |
|
@jakezatecky Can we get a review on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be really nice if we could do the following:
At the moment, only the required keys are returned and therefore
myCustomKeyabove is undefined.