Skip to content

Commit

Permalink
Minor cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
jakezatecky committed Feb 25, 2024
1 parent 9180dd6 commit 482d394
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions src/d3-funnel/D3Funnel.js
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,7 @@ class D3Funnel {
} else {
// Revert velocity back to the initial if we are using
// static heights (prevents zero velocity if isInverted
// and bottomPinch are non trivial and dynamicHeight is
// and bottomPinch are non-trivial and dynamicHeight is
// false)
if (!this.settings.dynamicHeight) {
({ dx } = this);
Expand Down Expand Up @@ -895,8 +895,8 @@ class D3Funnel {
addBeforeTransition(path, index, isOverlay) {
const paths = isOverlay ? this.overlayPaths[index] : this.blockPaths[index];

let beforePath = '';
let beforeFill = '';
let beforePath;
let beforeFill;

// Construct the top of the trapezoid and leave the other elements
// hovering around to expand downward on animation
Expand All @@ -919,11 +919,11 @@ class D3Funnel {
]);
}

// Use previous fill color, if available
if (this.settings.fillType === 'solid' && index > 0) {
// Use previous fill color, if available
beforeFill = this.blocks[index - 1].fill.actual;
// Otherwise use current background
} else {
// Otherwise use current background
beforeFill = this.blocks[index].fill.actual;
}

Expand Down
2 changes: 1 addition & 1 deletion webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ function makeConfig({ target }) {
},
},
resolve: {
extensions: ['.js', '.jsx'],
extensions: ['.js'],
},
externals: [
{
Expand Down

0 comments on commit 482d394

Please sign in to comment.