Rego1000 3.14 variables #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Would you mind adding a smoke test for it here: https://github.com/jagheterfredrik/esphome-rego1000/blob/main/.github/workflows/esphome.yml (in this PR)? 🙏 |
|
Sure - done! |
|
How do you suggest to handle the Energy output sensor? Personally I will probably not use it but is there a way to have conditional sensors depending on the version? Such sensors can of course be moved to the variable yaml but that would mess up your architecture... |
|
Thank you for your contribution 🙏 Let's 🙈 regarding the sensor, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jagheterfredrik an amazing piece of code you have put together - many thanks for that!
I just got a new IVT Greenline HE installed and have for now connected an ESP32-EVB board running the Rego 1000 component.
The firmware release in the rego1000 is 3.14 why I had to create a new configuration, the result is shared in this PR.
The parameters for ENERGY_OUTPUT has changed between 3.9 and 3.14. What I can see there is no data for the overall energy that has a good match with the sensor you have defined. Not really sure what is the best way to handle, but for now I have just commented out that sensor.