Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix license method issues #275

Merged
merged 7 commits into from
Dec 5, 2024
Merged

Fix license method issues #275

merged 7 commits into from
Dec 5, 2024

Conversation

jadolg
Copy link
Owner

@jadolg jadolg commented Dec 5, 2024

  • Add new license method and skip the deprecated one when testing v7
  • Temporarily skip channels_online (broken on v7)
  • Add semver to testing dependencies

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.55%. Comparing base (694e4f0) to head (eb3ce92).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
tests/conftest.py 77.77% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
+ Coverage   97.54%   97.55%   +0.01%     
==========================================
  Files          43       43              
  Lines        1708     1719      +11     
  Branches       86       87       +1     
==========================================
+ Hits         1666     1677      +11     
  Misses         32       32              
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Dec 5, 2024

@jadolg jadolg merged commit 5a2280f into master Dec 5, 2024
39 of 40 checks passed
@jadolg jadolg deleted the fix-license-method-v7 branch December 5, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant