Fixed for 1.8

[mmdanggg2]

No description provided.

[jadar]

The question is: should we really update for 1.8 in light of the EULA changed prohibiting cape mods?

On Jan 1, 2015, at 10:49 AM, James Horsley [email protected] wrote:

You can merge this Pull Request by running

git pull https://github.com/mmdanggg2/DeveloperCapes 1.8
Or view, comment on, or merge it at:

#37

Commit Summary

Fixed for 1.8
File Changes

M build.gradle (4)
M src/demo/java/net/jadar/devcapesdemo/DevCapesDemo.java (10)
M src/main/java/com/jadarstudios/developercapes/HDImageBuffer.java (6)
M src/main/java/com/jadarstudios/developercapes/RenderEventHandler.java (28)
M src/main/java/com/jadarstudios/developercapes/cape/CapeConfigManager.java (1)
M src/main/java/com/jadarstudios/developercapes/cape/StaticCape.java (22)
Patch Links:

https://github.com/jadar/DeveloperCapes/pull/37.patch
https://github.com/jadar/DeveloperCapes/pull/37.diff
—
Reply to this email directly or view it on GitHub.

[mmdanggg2]

Oh? I didn't know about that.

After having a quick look it seems as though mod capes are frowned upon but not banned.
https://twitter.com/Dinnerbone/status/425037592200224768

[jadar]

That was at the start of this year. This news just came in June.

https://mojang.com/2014/06/lets-talk-server-monetisation/ https://mojang.com/2014/06/lets-talk-server-monetisation/

On Jan 1, 2015, at 12:30 PM, James Horsley [email protected] wrote:

Oh? I didn't know about that.

After having a quick look it seems as though mod capes are frowned upon but not banned.
https://twitter.com/Dinnerbone/status/425037592200224768 https://twitter.com/Dinnerbone/status/425037592200224768
—
Reply to this email directly or view it on GitHub #37 (comment).

[mmdanggg2]

hmm, the only other thing is that the whole eula thing was all about servers specifically and a mod like this has nothing to do with servers.

[jadar]

But it is still giving capes away for free, and they are really only “useful” on servers..

On Jan 2, 2015, at 5:19 AM, James Horsley [email protected] wrote:

hmm, the only other thing is that the whole eula thing was all about servers specifically and a mod like this has nothing to do with servers.

—
Reply to this email directly or view it on GitHub #37 (comment).

[connor44566]

But so does optifine, but the exception is its only visible to people who use the mod / library,
P.s sorry for resurecting the thread

[maxhynes]

Has been pushed?

[xJon]

@mmdanggg2 Any idea why this doesn't work in 1.8.9?

[16:41:58] [Client thread/INFO] [STDERR/]: [xjon.developercapes.cape.StaticCape:loadTexture:52]: java.lang.NoSuchFieldException: playerInfo
[16:41:58] [Client thread/INFO] [STDERR/]: [xjon.developercapes.cape.StaticCape:loadTexture:52]:    at java.lang.Class.getDeclaredField(Unknown Source)
[16:41:58] [Client thread/INFO] [STDERR/]: [xjon.developercapes.cape.StaticCape:loadTexture:52]:    at xjon.developercapes.cape.StaticCape.loadTexture(StaticCape.java:41)
[16:41:58] [Client thread/INFO] [STDERR/]: [xjon.developercapes.cape.StaticCape:loadTexture:52]:    at xjon.developercapes.RenderEventHandler.renderPlayer(RenderEventHandler.java:38)
[16:41:58] [Client thread/INFO] [STDERR/]: [xjon.developercapes.cape.StaticCape:loadTexture:52]:    at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_8_RenderEventHandler_renderPlayer_Pre.invoke(.dynamic)
[16:41:58] [Client thread/INFO] [STDERR/]: [xjon.developercapes.cape.StaticCape:loadTexture:52]:    at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:49)
[16:41:58] [Client thread/INFO] [STDERR/]: [xjon.developercapes.cape.StaticCape:loadTexture:52]:    at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:140)
[16:41:58] [Client thread/INFO] [STDERR/]: [xjon.developercapes.cape.StaticCape:loadTexture:52]:    at net.minecraft.client.renderer.entity.RendererLivingEntity.func_76986_a(RendererLivingEntity.java:89)
[16:41:58] [Client thread/INFO] [STDERR/]: [xjon.developercapes.cape.StaticCape:loadTexture:52]:    at net.minecraft.client.renderer.entity.RenderPlayer.func_76986_a(RenderPlayer.java:63)
[16:41:58] [Client thread/INFO] [STDERR/]: [xjon.developercapes.cape.StaticCape:loadTexture:52]:    at net.minecraft.client.renderer.entity.RenderPlayer.func_76986_a(RenderPlayer.java:23)
[16:41:58] [Client thread/INFO] [STDERR/]: [xjon.developercapes.cape.StaticCape:loadTexture:52]:    at net.minecraft.client.renderer.entity.RenderManager.func_147939_a(RenderManager.java:375)
[16:41:58] [Client thread/INFO] [STDERR/]: [xjon.developercapes.cape.StaticCape:loadTexture:52]:    at net.minecraft.client.renderer.entity.RenderManager.func_147936_a(RenderManager.java:332)
[16:41:58] [Client thread/INFO] [STDERR/]: [xjon.developercapes.cape.StaticCape:loadTexture:52]:    at net.minecraft.client.renderer.entity.RenderManager.func_147937_a(RenderManager.java:299)
[16:41:58] [Client thread/INFO] [STDERR/]: [xjon.developercapes.cape.StaticCape:loadTexture:52]:    at net.minecraft.client.renderer.RenderGlobal.func_180446_a(RenderGlobal.java:652)
[16:41:58] [Client thread/INFO] [STDERR/]: [xjon.developercapes.cape.StaticCape:loadTexture:52]:    at net.minecraft.client.renderer.EntityRenderer.func_175068_a(EntityRenderer.java:1316)
[16:41:58] [Client thread/INFO] [STDERR/]: [xjon.developercapes.cape.StaticCape:loadTexture:52]:    at net.minecraft.client.renderer.EntityRenderer.func_78471_a(EntityRenderer.java:1230)
[16:41:58] [Client thread/INFO] [STDERR/]: [xjon.developercapes.cape.StaticCape:loadTexture:52]:    at net.minecraft.client.renderer.EntityRenderer.func_181560_a(EntityRenderer.java:1058)
[16:41:58] [Client thread/INFO] [STDERR/]: [xjon.developercapes.cape.StaticCape:loadTexture:52]:    at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1051)
[16:41:58] [Client thread/INFO] [STDERR/]: [xjon.developercapes.cape.StaticCape:loadTexture:52]:    at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:349)
[16:41:58] [Client thread/INFO] [STDERR/]: [xjon.developercapes.cape.StaticCape:loadTexture:52]:    at net.minecraft.client.main.Main.main(SourceFile:124)
[16:41:58] [Client thread/INFO] [STDERR/]: [xjon.developercapes.cape.StaticCape:loadTexture:52]:    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[16:41:58] [Client thread/INFO] [STDERR/]: [xjon.developercapes.cape.StaticCape:loadTexture:52]:    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
[16:41:58] [Client thread/INFO] [STDERR/]: [xjon.developercapes.cape.StaticCape:loadTexture:52]:    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
[16:41:58] [Client thread/INFO] [STDERR/]: [xjon.developercapes.cape.StaticCape:loadTexture:52]:    at java.lang.reflect.Method.invoke(Unknown Source)
[16:41:58] [Client thread/INFO] [STDERR/]: [xjon.developercapes.cape.StaticCape:loadTexture:52]:    at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
[16:41:58] [Client thread/INFO] [STDERR/]: [xjon.developercapes.cape.StaticCape:loadTexture:52]:    at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
[16:41:58] [Client thread/ERROR] [DevCapes/]: Setting cape ResourceLocation failed!```

[mmdanggg2]

I think this is just a problem with the field names, because the fix relies on super hacky reflection stuff it is very hard to get it working. It doesn't help that the field name is different in the dev environment than in the compiled game.

Take a look at the version of the fix in this: LINK It should work for 1.8.9

[xJon]

Thank you @mmdanggg2, it works. Also, I just understood, you're the author of the Doge mod!
I'm the author of The 1.7.10 Pack, that has over 400,000 downloads, and has your mod in it, so FYI :)

By the way, I noticed that you didn't have the right values for 1.9.4 or 1.10.2 yet, and neither do I, so maybe we should look at this class by @aidancbrady (notice which branch you're looking at), I hope it helps.

Edit: I used the code from your 1.9.4 branch and the value from the class above and it works on my 1.10.2 client! Edit 2: The same code works for 1.9.4 clients, too. Edit 3: It's kind of screwed with the Elytra wings, unfortunately.

[xJon]

Any idea, @mmdanggg2?

[Wehavecookies56]

I've updated it in my mod here

[xJon]

@Wehavecookies56 And how does this work with the Elytra wings?