[sigma,layer-leaflet/maplibre] using killLayer to properly remove m…
#1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- @sigma/[email protected] - @sigma/[email protected] - [email protected]
…ap container Change the `killLayer` to allow removing none canvas/webgl layers which can be created by `createLayer`. Using it in map layer in the clean function.
jacomyal
force-pushed
the
bsi/map-layer-lifecycle
branch
from
d3263c9
to
aeaeaaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you :
cleanfunction provided by the pluginThen you will have an error :
a layer named "layer-leaflet" already exists.Fix
killLayerto allow removing none canvas/webgl layers which can be created bycreateLayer.killLayerto properly remove map container