[layer-leaflet/maplibre] Fixing container resizing #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the function `createLayer`wich is a refacto of the `createCanvas` on which we can specify the html tag. The `createCanvas` functionality stays unchanged.
The resize event is now emitted when the new size has been applied.
… the width of the sigma container
When the container height/width changed (programmatically, ie not a resize event), the map layer was not updated or badly. By creating the map's container via the sigma API and by invalidate the map's size, the issue is fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the container height/width changed (programmatically, ie not a resize event), the map layer was not updated or badly.
A "Change width" button has been added on the map layer stories to reproduce the issue.
Changes
Sigma
createLayerfunction to allow to specify the HTML tag we want to createresizeevent when the resize is appliedlayer-leaflet & layer-maplibre
createLayerfunction to create thedivmap container