Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(intl-tel-input.ts): add @vite-ignore comment #1727

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

mihai-ro
Copy link
Contributor

Changes

  • chore(intl-tel-input.ts): add @vite-ignore comment to webpackIgnore directive to ensure Vite ignores the path during bundling

…irective to ensure Vite ignores the path during bundling
@jackocnr
Copy link
Owner

Thanks for this, could you run npm run build:js to build the JS files and commit those too? (See contributing guide for more info)

@mihai-ro
Copy link
Contributor Author

Thanks for this, could you run npm run build:js to build the JS files and commit those too? (See contributing guide for more info)

Jack, I absolutely can and just did :) thank you for your hard work! is there anything else that I could help with?

@jackocnr jackocnr merged commit 67274e5 into jackocnr:master Jul 30, 2024
1 check passed
@jackocnr
Copy link
Owner

Excellent, thanks. I'll do a new release in the morning.

@jackocnr
Copy link
Owner

jackocnr commented Jul 30, 2024

That's released in v23.7.4.

is there anything else that I could help with?

That's so kind of you to offer, Mihai! One thing that would be really helpful, if you have time, is to help with the test migration. Even if it was just moving over one or two tests that would be helpful! For example, translating the existing Jasmine test file /src/spec/tests/options/allowDropdown.js to the new Jest test file /test/options/allowDropdown.test.js (see the other Jest tests for examples).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants