Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use module-level loggers #127

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Use module-level loggers #127

wants to merge 2 commits into from

Conversation

lkraider
Copy link
Collaborator

Use module-level loggers so that implementers can configure the logging in more granular ways.

The logging module when used directly defaults to the root logger, which while easy to use, does not allow for much control for printing/silencing different modules logging output when on larger projects.

Using the standard of instantiating a logger using the module name still keeps logging usage simple, while adding better control, and also helps to show where specific messages are being generated from.

Also the log_level parameter is removed from the app initialization, since this is automatically provided by the logging module (users can configure the root module or any named module anywhere before starting the app). A good place for that would be in a settings part of the client app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant