Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialect Conversion #20

Merged
merged 15 commits into from
Oct 21, 2023
Merged

Dialect Conversion #20

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
05a17d1
Add poly-to-standard lowering pass shell
j2kun Sep 22, 2023
d9bcf1f
Add conversion target
j2kun Sep 22, 2023
3421df1
add poly type converter
j2kun Sep 22, 2023
78bf9a5
add empty lowering for poly.add
j2kun Oct 20, 2023
bf9fbc9
lower poly.add
j2kun Oct 20, 2023
25b284b
add structural conversion helpers for func, etc.
j2kun Oct 20, 2023
191b7b0
add poly.to_tensor op
j2kun Oct 19, 2023
e99916b
lower poly sub, to_tensor, from_tensor ops
j2kun Sep 23, 2023
b8c4d86
lower poly.constant
j2kun Sep 22, 2023
46aa345
lower poly.mul as a naive loop
j2kun Oct 19, 2023
06de5d2
Lower poly.eval
j2kun Oct 19, 2023
46ff536
add CMake build files
j2kun Oct 20, 2023
b8f089b
add a test that chains together many poly ops
j2kun Oct 20, 2023
edf22e4
demonstrate what a materialization would involve
j2kun Oct 20, 2023
c3a8384
Revert "demonstrate what a materialization would involve"
j2kun Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions lib/Conversion/PolyToStandard/PolyToStandard.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,20 @@ class PolyToStandardTypeConverter : public TypeConverter {
}
};

struct ConvertAdd : public OpConversionPattern<AddOp> {
ConvertAdd(mlir::MLIRContext *context)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure of before but in MLIR 17+, I've had to instead implement this constructor,

ConvertAdd(TypeConverter& type_converter, MLIRContext* context)
    : OpConversionPattern<AddOp>(type_converter, context) {}

otherwise the call to patterns.add<ConvertAdd>(typeConverter, context); fails at compile time saying no matching constructor for initialization since the constructor we implemented here requires one argument but we provide two.

Also, it maybe just a minor preference thing but struct A : public B is equivalent to struct A : B since structs have public inheritance by default.

: OpConversionPattern<AddOp>(context) {}

using OpConversionPattern::OpConversionPattern;

LogicalResult matchAndRewrite(
AddOp op, OpAdaptor adaptor,
ConversionPatternRewriter &rewriter) const override {
// TODO: implement
return success();
}
};

struct PolyToStandard : impl::PolyToStandardBase<PolyToStandard> {
using PolyToStandardBase::PolyToStandardBase;

Expand All @@ -40,9 +54,12 @@ struct PolyToStandard : impl::PolyToStandardBase<PolyToStandard> {
auto *module = getOperation();

ConversionTarget target(*context);
target.addLegalDialect<arith::ArithDialect>();
target.addIllegalDialect<PolyDialect>();

RewritePatternSet patterns(context);
PolyToStandardTypeConverter typeConverter(context);
patterns.add<ConvertAdd>(typeConverter, context);

if (failed(applyPartialConversion(module, target, std::move(patterns)))) {
signalPassFailure();
Expand Down