Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring getDbo() in backend component #90

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mckillo
Copy link

@mckillo mckillo commented Nov 10, 2024

Refactong: Use Factory::getContainer()->get('DatabaseDriver'), avoid deprecated in administrator\components\com_j2store\

mckillo and others added 3 commits November 10, 2024 13:26
Refactong: Use Factory::getContainer()->get('DatabaseDriver'), avoid deprecated in administrator\components\com_j2store\
@newlinewebdesign
Copy link

We aren't going to be able to merge this PR into the upcoming release as the current reference would break any backwards compatibility with Joomla 3 and not allow those who haven't migrated yet to do so. We are looking into alternative solutions after this release. We all appreciate the work you have done and wanted to make sure you understood why it wasn't included in this release.

@mckillo
Copy link
Author

mckillo commented Nov 11, 2024

I'm sorry, I didn’t think this branch was intended to support Joomla 3. I thought it was meant to update the code to make it compatible with the current version, Joomla 5, and prepare the package for migration. If that’s the case, maintaining support for Joomla 3 doesn’t make sense, nor does approving the PR github.com/J2Store4/j2store4/commit/8ba3d9060e44efe493f8b1e79bea92aadf365f51 or other code changes where the getDbo refactoring has already been done. Thank you for the information and for letting me know.
You can close this PR.

@brianteeman
Copy link

There really needs to be a different branch

#74 (comment)

@mckillo
Copy link
Author

mckillo commented Nov 11, 2024

I installed a new J2Store on Joomla 5.2.1 without any migration, and the PR was created with J5 support in mind.

@brianteeman
Copy link

~The problem is as I described in the linked issue. Users on an older version of j2store and joomla 3 need to update j2store first and then joomla. Thats why we need to keep this version compatible with j3 so users can update and then update to a future version which is j4/5/6 only

@newlinewebdesign
Copy link

@brianteeman we are considering whether to make versions 4.0.8 the last version that can be used to migrate from J3 , but we will definitely be starting a new branch for the Joomla 6 version that will be 100% native J5+ as discussed previously. This main branch was created to give J3 users the confidence to migrate to J4/5 and to give current J4/5 users the confidence and tools needed to properly manage their stores.

@j2commerce j2commerce added this to the J2Store 4.1.0 milestone Nov 21, 2024
@mckillo
Copy link
Author

mckillo commented Nov 21, 2024

When will a new branch for version 4.1.0 for J5 be opened? I’m interested in contributing by testing and debugging this version.

@newlinewebdesign
Copy link

@mckillo we have implemented some installer checks in version 4.0.9 onwards that will prevent the install of j2store v4 from being installed on joomla 3 sites. The newly updated migration tool will install a previous version of j2store 4 without any of the breaking changes found in later versions so this PR will be getting merged into the 4.1.0 version (if not sooner) thanks again for all of your contributions and now that the handcuffs are taken off, feel free to be a part of this as much as you wish.

@mckillo
Copy link
Author

mckillo commented Nov 26, 2024

OK, thanks. I take a note of it, and as soon as I have time, I’ll get to it. I quess that you will open a new branch to the version 4.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants