Update Variant Off Canvas View with Variant/Product Images #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Updated depricated J classes with namespaced versions - Updated more info button with nowrap bs5 class for mobile view
-Updated depricated J classes with namespaced versions - Updated more info button with nowrap bs5 class for mobile view
-Updated depricated J classes with namespaced versions - Updated copyright notice - Updated more info button with nowrap bs5 class for mobile view
-Updated depricated J classes with namespaced versions - Updated copyright notice - Updated more info button with nowrap bs5 class for mobile view
…d views/xml cleanup
…list.php another new thing to learn:) Co-authored-by: Brian Teeman <[email protected]>
…ay of directory names
This reverts commit 3f2c282.
…o order-page-updates-11-12-24
brianteeman
reviewed
Nov 16, 2024
administrator/components/com_j2store/controllers/traits/list_view.php
Outdated
Show resolved
Hide resolved
brianteeman
reviewed
Nov 16, 2024
|
When you start a new pull request you should always do it from a branch of main not of your last pull request. Otherwise you get this PR including all the proposed changes from your other pull requests |
|
Brian,
Thanks. I am still trying to get a handle on this. I have been trying to
figure out why it kept pulling in the previous PRs even though I was
creating a new branch, now I know why it wasn't working properly.
Adam
*Adam Melcher*
New Line Web Design
***@***.***
t 615.208.6141
www.newlinewebdesign.com
…On Sat, Nov 16, 2024 at 2:56 AM Brian Teeman ***@***.***> wrote:
When you start a new pull request you should always do it from a branch of
main not of your last pull request. Otherwise you get this PR including all
the proposed changes from your other pull requests
—
Reply to this email directly, view it on GitHub
<#105 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANAUB5LD2MGI4K2A465CTTL2A4CDFAVCNFSM6AAAAABR4GMBMCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBQGQ4DIMZQGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
…iew.php Co-authored-by: Brian Teeman <[email protected]>
Co-authored-by: Brian Teeman <[email protected]>
|
You were creating a new branch from the one you had been working on. You always need to create a new branch of the main branch |
|
Yes, your last post helped me realize what my issue was. I really do
appreciate all the help and support you've given this project.
…On Sat, Nov 16, 2024, 11:05 AM Brian Teeman ***@***.***> wrote:
You were creating a new branch from the one you had been working on. You
always need to create a new branch of the main branch
—
Reply to this email directly, view it on GitHub
<#105 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANAUB5MSE5UWYZNOXKV5N432A53NFAVCNFSM6AAAAABR4GMBMCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBQGY3DONJYGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.