Advising (compat-function completion-metadata-get). Fix #32 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ising (compat-function completion-metadata-get). Fix iyefrat#32
winny-
added a commit
to winny-/emacs.d
that referenced
this pull request
Jul 17, 2024
grab fix from iyefrat/all-the-icons-completion#33 as submodule battery bar mode works again ensure vimish-fold loads remove unused major mode
|
Thanks, tested and working for me |
|
Working fine for me. LGTM! |
archer-65
added a commit
to archer-65/nix-dotfiles
that referenced
this pull request
Aug 17, 2024
- Resolve `setup.el` deprecation for `bind-into` map string. - `all-the-icons-completion` experienced issues with `marginalia`; check iyefrat/all-the-icons-completion#33
|
Also works for me, emacs 29.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following minad/marginalia@f2ac221, compatibility with Marginalia was broken. Advising
(compat-function completion-metadata-get)restores it. Fixes #32.