Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incompatibility between all-the-icons-completion and latest Melpa version of marginalia #32

Open
maxecharel opened this issue Jul 9, 2024 · 2 comments · May be fixed by #33
Open

incompatibility between all-the-icons-completion and latest Melpa version of marginalia #32

maxecharel opened this issue Jul 9, 2024 · 2 comments · May be fixed by #33

Comments

@maxecharel
Copy link

maxecharel commented Jul 9, 2024 •
edited
Loading

Hi,

After having upgraded marginalia to its latest Melpa version (20240708.2158), icons disappeared from minibuffer completion.
I've filled an issue on marginalia's issue tracker (minad/marginalia#175) , and @minad suggested that all-the-icons-completion would require an update following a recent commit to marginalia: minad/marginalia@f2ac221

Doable on your side?

Many thanks for your work!

Best,
M
@PvonN
Copy link

PvonN commented Jul 9, 2024

Same issue here!

@maxecharel
Copy link
Author

Same issue here!

Hi, check my comment on minad/marginalia#175 for a fix implying redefining the minor-mode; I may submit a PR tomorrow but first I would like to take the time to understand the issue with Corfu + Cape + ESS-R

maxecharel pushed a commit to maxecharel/all-the-icons-completion that referenced this issue Jul 10, 2024
@maxecharel
Restore compatibility with Marginalia following commit f2ac221 by adv…
3f5282f 
…ising (compat-function completion-metadata-get). Fix iyefrat#32
@maxecharel maxecharel linked a pull request Jul 10, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Advising (compat-function completion-metadata-get). Fix #32 maxecharel/all-the-icons-completion
2 participants
@maxecharel @PvonN