ivy.index_add

[imsoumya18]

PR Description

Related Issue

Closes #26801

Checklist

• Did you add a function?
• Did you add the tests?
• Did you run your tests and are your tests passing?
• Did pre-commit not fail on any check?
• Did you follow the steps we provided?

Socials

Twitter

[github-actions]

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

• docs: correct typo in README
• feat: implement dark mode"
• fix: correct remove button behavior

Linting Errors

• Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
• No subject found

[github-actions]

Thank you for this PR, here is the CI results:

---

This pull request does not result in any additional test failures. Congratulations!

[imsoumya18]

@saeedashrraf please review this PR

[vedpatwardhan]

Thanks for making the changes, the tests seem to be failing with tensorflow which fails the tests with all backends (because tensorflow is the ground truth). I'll also request @NripeshN's review who'd be able to suggest the further steps , thanks @imsoumya18 😄

[vedpatwardhan]

Hey @imsoumya18, @NripeshN would be reviewing the PR soon (as he's assigned to the PR). Thanks 😄

[imsoumya18]

Hey @imsoumya18, @NripeshN would be reviewing the PR soon (as he's assigned to the PR). Thanks 😄

Yes, please. I have been waiting since October for this PR. If needed we can schedule a meeting. I am really worried about this one. Thank you 😄

[vedpatwardhan]

Hey @imsoumya18, sorry just realized one thing, isn't this function be the same as ivy.scatter_nd with sum being the reduction? Was it present on a ToDo list cuz ideally this function shouldn't have been on a ToDo list. Thanks 😄

[imsoumya18]

Hey @imsoumya18, sorry just realized one thing, isn't this function be the same as ivy.scatter_nd with sum being the reduction? Was it present on a ToDo list cuz ideally this function shouldn't have been on a ToDo list. Thanks 😄

Actually I was implementing index_add #26394 & index_add_ #26761 in Paddle frontend as listed as ToDo in #15037

Then, I got this review and I paused the above 2 and this issue is still pending since then. Whereas the actual 2 was completed but not merged until it is being done.

[vedpatwardhan]

Hey @imsoumya18, sorry just realized one thing, isn't this function be the same as ivy.scatter_nd with sum being the reduction? Was it present on a ToDo list cuz ideally this function shouldn't have been on a ToDo list. Thanks 😄

Actually I was implementing index_add #26394 & index_add_ #26761 in Paddle frontend as listed as ToDo in #15037

Then, I got this review and I paused the above 2 and this issue is still pending since then. Whereas the actual 2 was completed but not merged until it is being done.

Got it, thanks for clarifying! I completely agree with the point @hello-fri-end made, the frontend implementations shouldn't be as long and we should do most of the heavy-lifting in the ivy api itself. However, I suspect using ivy.scatter_nd with the sum reduction might actually end up making the frontend implementation compact enough without the need of adding a new function to ivy itself. Could you please try using ivy.scatter_nd in the frontend implementation and see if the tests pass? Thanks @imsoumya18 😄

[imsoumya18]

NO MORE NEEDED