Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates based on RFC comments #62

Merged
merged 6 commits into from
Nov 25, 2024

Conversation

tomdonaldson
Copy link
Contributor

@tomdonaldson tomdonaldson commented Nov 16, 2024

This contains several small additions and clarifications based on RFC comments to date:

  • Added MIVOT to the architecture diagram
  • Added a sentence to clarify the (non)advice for ordering of ID and ref attributes.
  • Adopted suggestion to calling out the equivalence of ET and TT timescale
  • Clarified that MIVOT elements are allowed with the VOTable schema.
  • Adopted suggested wording change about the use of type="meta" for a MIVOT RESOURCE.
  • Corrected an attribute name in a LINK example in section A4. This makes the example schema compliant though there are other issues with the example that won't be fixed for v1.5.

Copy link
Member

@mbtaylor mbtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine apart from one comment.

VOTable.tex Outdated Show resolved Hide resolved
@gmantele
Copy link

  • Added a sentence to clarify the (non)advice for ordering of ID and ref attributes.

I am fine with the added clarification about this second point. Thank you 🙂

@tomdonaldson tomdonaldson merged commit 5a681b4 into ivoa-std:master Nov 25, 2024
1 check passed
@tomdonaldson tomdonaldson mentioned this pull request Nov 25, 2024
@tomdonaldson tomdonaldson added this to the v1.5 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants