Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build.yml #96

Merged

Conversation

loumir
Copy link
Collaborator

@loumir loumir commented Sep 13, 2024

trial to fix issue in generating PDF :
upgraded version for upload/artifact. use v4.

trial to fix issue in generating PDF : 
upgraded  version for upload/artifact. use v4.
@loumir loumir self-assigned this Sep 18, 2024
@loumir loumir assigned msdemlei and BaptisteCecconi and unassigned loumir Sep 18, 2024
@loumir
Copy link
Collaborator Author

loumir commented Sep 18, 2024

I had an error in the workflow during the processing made by git .
I have proposed an update on .github/workflows/build.yml that allows the full compilation .

Copy link
Contributor

@msdemlei msdemlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... I have to say I don't understand much of github's CI, and, it being a proprietary service, I'm not too wild on spending a lot of effort learning much about it. Hence, I have no idea what this change does and cannot usefully review.

The respective code was contributed to ivoatex by @gmantele – I think he's a much better reviewer than me.

@BaptisteCecconi BaptisteCecconi merged commit f182d02 into master Sep 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants