Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cross-refs and clarify overflow #34

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Conversation

pdowler
Copy link
Collaborator

@pdowler pdowler commented Nov 27, 2023

Copy link
Contributor

@msdemlei msdemlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I would still at least consider saying "if you can, indicate overflows in simple formats by setting the file name to something containing '-truncated'" or so – often, there is no streaming to the client involved and it is hence not hard to do that – I wont' belabour that point.

Of course +2 on fixing the baked-in references.

@mbtaylor
Copy link
Member

My take on the overflow business is that file formats like CSV are just underpowered for that sort of thing - if you care about detecting overflows use a format that can do it, i.e. VOTable. If people want to (and can) smuggle messages into filenames good luck to them, but writing it into the standard puts something of a burden on clients to look for that behaviour.

@pdowler pdowler merged commit 2204e71 into ivoa-std:master Nov 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants