send query string instead of range http header #5087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unixfox
requested review from
SamantazFox and
syeopite
and removed request for
a team
|
Last time I tested this it didn't work with Invidious' own video proxy, which is why FreeTube still sends the range header instead of the query parameter. I haven't tested this specific pull request though, so maybe it is different with this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send the range using query string like the YouTube player do.
This avoids having to do some processing inside Invidious and just straight send the correct query string to YouTube servers.
Makes it easier to be compatible with other videoplayback proxies like http3-ytproxy or piped-proxy. Especially the last one because piped only use query string now for the range.
Copied from https://github.com/FreeTubeApp/FreeTube/blob/540a5a9385859d855a5989467323414d16470d8a/src/renderer/components/ft-shaka-video-player/ft-shaka-video-player.js#L1101-L1103