Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI: GHC 9.10, update and cleanup shell.nix #267

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Update CI: GHC 9.10, update and cleanup shell.nix #267

merged 3 commits into from
Oct 18, 2024

Conversation

ulysses4ever
Copy link
Collaborator

@ulysses4ever ulysses4ever commented Jul 8, 2024 •
edited
Loading

I do it in separate commits because these changes are loosely related but I want to save on round-trips with reviews. In particular, in this PR I

  • add GHC 9.10 to CI,
  • update and cleanup shell.nix:
    • update to the latest nixpkgs release
    • add callCabal2Nix to get the Haskell dependencies through Nix too
  • add a GitHub workflow testing shell.nix (thanks to not building Haskell dependencies it finishes before the current longest running job with integration tests, therefore not slowing down the CI).

@ulysses4ever ulysses4ever linked an issue Jul 8, 2024 that may be closed by this pull request
Update to GHC 9.10 #257
Closed
3 tasks
vidsinghal
vidsinghal approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@vidsinghal vidsinghal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulysses4ever ulysses4ever merged commit 3688a1f into iu-parfunc:main Oct 18, 2024
11 checks passed
@ulysses4ever ulysses4ever deleted the more-ci branch October 19, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vidsinghal vidsinghal vidsinghal approved these changes

@ckoparkar ckoparkar Awaiting requested review from ckoparkar

@vollmerm vollmerm Awaiting requested review from vollmerm

@rrnewton rrnewton Awaiting requested review from rrnewton

@jazullo jazullo Awaiting requested review from jazullo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to GHC 9.10
2 participants
@ulysses4ever @vidsinghal