-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments: Fix add1Tree cursorize example #252
base: main
Are you sure you want to change the base?
Conversation
Node -> ... | ||
|
||
Every packed input becomes a read cursor. And it takes additional output cursors | ||
for every packed type in the return value. Every packed return value becomes a | ||
(Cursor,Cursor) i.e (start,end). And it returns additional end_of_read cursors | ||
if the functions "traverses" it's input (more details in the paer). | ||
|
||
if the functions "traverses" it's input (more details in the paper). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the functions "traverses" it's input (more details in the paper). | |
if the functions "traverses" its input (more details in the paper). |
One day we'll add doctests, and all those commented out examples will be checked... I hope! |
To introduce the notion of mutable cursors, would it not be ideal if we just change lout in the example to a mutable cursor since we still want the read cursors to be non-mutable @rrnewton ?
For mutable cursor case, this potentially turns into something like
For the return type, there are 2 possibilities, we could still return the start location and end location of the Packed type |
No description provided.