Fix the handling of gibbon runtime args and usage help #228

vidsinghal · 2023-10-08T17:14:46Z

No description provided.

ulysses4ever

I'm trying to get myself familiar with the codebase, and as a part of this effort, I'm keeping an eye and plan to review incoming changes. I hope this is not too annoying! Feel free to ignore my comments, 'cause they come from a newcomer!

gibbon-rts/rts-c/gibbon_rts.c

vidsinghal · 2023-10-08T17:58:56Z

I'm trying to get myself familiar with the codebase, and as a part of this effort, I'm keeping an eye and plan to review incoming changes. I hope this is not too annoying! Feel free to ignore my comments, 'cause they come from a newcomer!

sounds good @ulysses4ever
No, I actually prefer reviews. This is a good way to get quality code merged.

ulysses4ever · 2023-10-09T14:30:38Z

gibbon-rts/rts-c/gibbon_rts.c

+    printf(" --array-input <path>           Set the file from which to read the array input.\n");
+    printf(" --array-input-length <int>     Set the size of the array input file.\n");
+    printf(" --iterate <int>                Set the number of timing iterations to perform (default 1).\n");
+    printf(" --size-param <int>             A parameter for size available as a language primitive which allows user to specify the size at runtime (default 1).\n");


I can't say I understand this line, but maybe I just need to read more...

I am not 100% sure how to phrase this.
I see that SizeParam in a primitve in the gibbon std-lib. The compiler generates code to create a call to get this variable which is set as a runtime arg.

Maybe you have a suggestion to better phrase this?

Not at this point, I'm afraid. I'll have to dive deeper... For now, if no one objects, you could probably merge it as is.

sounds good to me. I can add a TODO here to recheck this later.

ulysses4ever

Sweet, thank you!

vidsinghal force-pushed the fix_gibbon_runtime_args branch from 421c97d to b1a5c10 Compare October 8, 2023 17:18

ulysses4ever reviewed Oct 8, 2023

View reviewed changes

vidsinghal force-pushed the fix_gibbon_runtime_args branch 2 times, most recently from 1f35fd1 to 1025cfd Compare October 9, 2023 13:59

vidsinghal requested a review from ulysses4ever October 9, 2023 14:00

vidsinghal force-pushed the fix_gibbon_runtime_args branch from 1025cfd to 170713b Compare October 9, 2023 14:01

ulysses4ever reviewed Oct 9, 2023

View reviewed changes

ulysses4ever approved these changes Oct 9, 2023

View reviewed changes

fix the handling of gibbon runtime args and usage help

2fd1098

vidsinghal force-pushed the fix_gibbon_runtime_args branch from 170713b to 2fd1098 Compare October 9, 2023 17:22

vidsinghal merged commit b8facf4 into main Oct 9, 2023
16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the handling of gibbon runtime args and usage help #228

Fix the handling of gibbon runtime args and usage help #228

vidsinghal commented Oct 8, 2023

ulysses4ever left a comment

vidsinghal commented Oct 8, 2023

ulysses4ever Oct 9, 2023

vidsinghal Oct 9, 2023

vidsinghal Oct 9, 2023

ulysses4ever Oct 9, 2023

vidsinghal Oct 9, 2023

ulysses4ever left a comment

Fix the handling of gibbon runtime args and usage help #228

Fix the handling of gibbon runtime args and usage help #228

Conversation

vidsinghal commented Oct 8, 2023

ulysses4ever left a comment

Choose a reason for hiding this comment

vidsinghal commented Oct 8, 2023

ulysses4ever Oct 9, 2023

Choose a reason for hiding this comment

vidsinghal Oct 9, 2023

Choose a reason for hiding this comment

vidsinghal Oct 9, 2023

Choose a reason for hiding this comment

ulysses4ever Oct 9, 2023

Choose a reason for hiding this comment

vidsinghal Oct 9, 2023

Choose a reason for hiding this comment

ulysses4ever left a comment

Choose a reason for hiding this comment