Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added myself as a contributor #2

Merged
merged 2 commits into from
Dec 19, 2016

Conversation

riskzorque
Copy link
Collaborator

No description provided.

@itslewiswatson itslewiswatson changed the title I'm a contributor :D Added myself as a contributor Dec 19, 2016
@itslewiswatson
Copy link
Owner

Hey @Risk36,

Glad to see you have GitHub. It's a shame you didn't have it before, because you can't get credited for all the changes you actually made.

Anyway, GitHub's pull request system takes a little getting used to. Once you fork a repo, you can request to merge one of your branches into one of the upstream repo's branches (the upstream repo would be the one you forked it from - so nokizorque/ucd).

And for every commit you make it that branch, it gets placed into the pull request. So it can be messy unless you create separate branches for separate pull requests. Think of it like a copy of the code for every change you want to merge.

I'll merge this one this time, but just keep that in mind for next time.

Thanks.

@itslewiswatson itslewiswatson merged commit be55dd1 into itslewiswatson:master Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants