Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed distribution path to kingpin.framework to fix #111 #114

Closed

Conversation

sshumway
Copy link
Contributor

Changed distribution_path to "$(pwd)/kingpin.frameworks" in build.sh to utilize carthage pre built framework feature. Fixes #111

@stanislaw
Copy link
Collaborator

@sshumway, are you talking about this ? I am wondering how changing that distribution_path can be related to the presence of .framework in the final attachment?

The attachment should include .framework in its name (e.g., ReactiveCocoa.framework.zip), to indicate to Carthage that it contains binaries.

Please elaborate a bit more.

@sshumway
Copy link
Contributor Author

Closing pull request. The correct structure for Carthage to download and use the binary directly is accomplished via

carthage build --no-skip-current
carthage archive YourFrameworkName

My change above will not create the right directory structure. Sorry!

@sshumway sshumway closed this Oct 23, 2015
@sshumway sshumway deleted the carthage_framework_filename branch January 10, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants