-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add abbr for artifact and model registry #4844
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dberenbaum
commented
Sep 7, 2023
Comment on lines
+40
to
+41
metadata fields (for example, to be consumed in the <abbr>model registry</abbr> | ||
or automation scenarios). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried to be consistent with how we refer to model registry throughout the docs
dberenbaum
commented
Sep 7, 2023
Comment on lines
-34
to
-38
Here we'll see artifacts that have Git tags or are annotated in | ||
`artifacts.yaml`. The artifacts that have annotation, but have no Git tags, are | ||
considered yet `unregistered` and will be marked with an asterisk, e.g. | ||
`*annotated`. Use `--all-branches` or `--all-commits` to read `artifacts.yaml` | ||
from more commits than just `HEAD`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks to be deprecated AFAICT
shcheklein
reviewed
Sep 7, 2023
shcheklein
reviewed
Sep 7, 2023
shcheklein
approved these changes
Sep 7, 2023
omesser
force-pushed
the
artifact-definition
branch
from
September 8, 2023 14:58
adf9754
to
de786e8
Compare
pushed formatting fix in de786e8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
<abbr>
with tooltips for two new basic concepts:artifact
andmodel registry
.