Apply some suggestions from code rabbit

itavero · Jan 4, 2025 · 524bd1a · 524bd1a
1 parent 3e2b9f2
commit 524bd1a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,7 +11,7 @@ Since version 1.0.0, we try to follow the [Semantic Versioning](https://semver.o
 
 - Light sensor will now use `illuminance` property if `illuminance_lux` is not available. This should fix compatibility with the new major v2 release of Zigbee2MQTT. (see [#966](https://github.com/itavero/homebridge-z2m/issues/966))
 - Brightness for a Light is no longer requested by default. This should prevent issues when the light is off.
-  Old behavior can be restored using the `request_brightness` option in the converter specific configuration.
+  Old behavior can be restored using the `request_brightness` option in the converter-specific configuration.
   (see [#882](https://github.com/itavero/homebridge-z2m/issues/882))
 
 ## [1.11.0-beta.6] - 2024-06-30

diff --git a/docs/light.md b/docs/light.md
@@ -26,7 +26,8 @@ The table below shows how the different features within this `exposes` entry are
       "adaptive_lighting": {
         "only_when_on": true,
         "transition": 0.5
-      }
+      },
+      "request_brightness": false
     }
   }
 }

diff --git a/src/converters/light.ts b/src/converters/light.ts
@@ -78,9 +78,7 @@ export class LightCreator implements ServiceCreator {
     let requestBrightness = false;
     let adaptiveLightingConfig: AdaptiveLightingConfig | undefined = undefined;
     if (isLightConfig(converterConfig)) {
-      if (converterConfig.request_brightness === true) {
-        requestBrightness = true;
-      }
+      requestBrightness = !!converterConfig.request_brightness;
       if (isAdaptiveLightingConfig(converterConfig.adaptive_lighting)) {
         adaptiveLightingConfig = converterConfig.adaptive_lighting;
       } else if (converterConfig.adaptive_lighting === true) {