[17.0] [MIG] portal_event_tickets #9

azimkhankuat · 2024-10-23T11:16:18Z

[17.0] [MIG] portal_event_tickets

Co-authored-by: Ivan Yelizariev <[email protected]> Co-authored-by: Alexandr Kolushov <[email protected]> Co-authored-by: Eugene Molotov <[email protected]> Co-authored-by: Victor Bykov <[email protected]> Co-authored-by: Ilmir Karamov <[email protected]>

…о вьюху

em230418

Частично проверил

em230418 · 2024-10-24T04:31:30Z

portal_event_tickets/views/event_registration.xml

                <p
-                    attrs="{'invisible': [('is_transferring', '=', False)]}"
                    style="color: red"
                >Ticket transferring was started, but haven't finished!</p>


Атрибут убрали, и его замены нету.

Атрибут убрали, и его замены нету.

Field 'is_transferring' used in modifier 'invisible' (is_transferring == False) is restricted to the group(s) base.group_no_one.

Ticket transferring was started, but haven't finished!

В таком случае надпимсь "Ticket transferring was started, but haven't finished!" будет постоянно видна.

Само поле is_transferring продублирируй и поставь невидимым рядом с этой надписью.

em230418 · 2024-10-24T04:47:41Z

portal_event_tickets/static/src/js/ticket_transfer.tour.esm.js

+                // $("input[name='1-phone']").val("111 111");
+                // $("select[name='1-country_id']").val("1");
+                $("input[type='email']").val("[email protected]");


Если c country_id понятно, ибо поле такого теперь нету. А вот почему phone убрали и поставили [email protected] - не понятно. Это ведь другой тест получится. Нужны пояснения.

К слову тут надо не комментировать, а удалять строки.

em230418 · 2024-10-24T04:48:37Z

portal_event_tickets/static/src/js/ticket_transfer.tour.esm.js

+                // * country_id (mandatory)
+                // skip:
+                // * job position (optional)


Тут просто удаляем упоминание про country_id и job position.

em230418 · 2024-10-24T04:52:32Z

portal_event_tickets/tests/common.py

+        # sale_order.onchange_partner_id()
+


Тут просто удаляем, не комментируем.

em230418 · 2024-10-24T05:16:36Z

portal_event_tickets/views/portal_templates.xml

+    <template
+        id="portal_my_home_event"
+        name="Portal My Home : event entries"
+        inherit_id="portal.portal_my_home"
+        priority="25"
+    >
+        <xpath expr="//div[hasclass('o_portal_docs')]" position="inside">
+            <t t-call="portal.portal_docs_entry">
+                <t t-set="title">Tickets</t>
+                <t t-set="url" t-value="'/my/tickets'" />
+                <t t-set="placeholder_count" t-value="'tickets_count'" />
+            </t>
+        </xpath>
+    </template>


Раздел Ticket выглядит уныло.

Исправить надо также, как когда-то исправлял Affilitates. https://github.com/it-projects-llc/tg-addons/pull/8/files/f53b3d0607dfcacf2a5a33199f1c7f47555f4f03#diff-ac9f3b765e4c8066fdb4848396a07024ae84b647bdff24d03be8e7157594172d

em230418 · 2024-10-24T05:21:19Z

portal_event_tickets/controllers/main.py

        registration["event_id"] = ticket.event_id.id
+        registration.pop("email", None)
        partner_vals = request.env["event.registration"]._prepare_partner(registration)


Зачем убираем почту?

em230418 · 2024-10-24T05:28:17Z

portal_event_tickets/controllers/main.py

+            default_first_attendee = {}
+            if ticket.attendee_partner_id:
+                default_first_attendee = {
+                    "name": ticket.attendee_partner_id.name,
+                    "phone": ticket.attendee_partner_id.phone,
+                    "country_id": ticket.attendee_partner_id.country_id.id,
+                }
            values.update(


country_id точно нужен?

Почему нету email?

em230418 · 2024-10-24T05:30:15Z

portal_event_tickets/controllers/main.py

            request.env.ref(registration_badge_template)
            .with_user(SUPERUSER_ID)
-            ._render_qweb_pdf([ticket.id])[0]
+            ._render_qweb_pdf(registration_badge_template, [ticket.id])[0]


Тогда уж request.env['ir.actions.report'], а не request.env.ref(registration_badge_template)

em230418 · 2024-10-30T10:47:08Z

portal_event_tickets/views/portal_templates.xml

            <t t-call="portal.portal_docs_entry">
                <t t-set="title">Tickets</t>
                <t t-set="url" t-value="'/my/tickets'" />
+                <t t-set="text">View your tickets</t>
+                <t
+                    t-set="icon"
+                    t-value="'/portal/static/src/img/portal-connection.svg'"
+                />
                <t t-set="placeholder_count" t-value="'tickets_count'" />
            </t>
        </xpath>


Заверни пожалуйста этот portal_docs_entry в раздел для клиентов. Как тут
https://github.com/odoo/odoo/blob/17.0/addons/account/views/account_portal_templates.xml#L20-L28

em230418 · 2024-10-30T10:58:21Z

portal_event_tickets/views/portal_templates.xml

+                            <li class="list-group-item flex-grow-1">
+                                <a
+                                    t-if="ticket.event_id.ticket_transferring"
+                                    role="button"
+                                    class="btn btn-primary btn-block mb8"
+                                    data-bs-toggle="modal"
+                                    data-bs-target="#transferTicketModal"
+                                    href="#"
+                                >
+                                    <i class="fa fa-exchange" />
+                                    Transfer to another person
+                                </a>
+                                <a
+                                    t-if="ticket.event_id.ticket_transferring"
+                                    role="button"
+                                    data-bs-toggle="modal"
+                                    data-bs-target="#changeTicketModal"
+                                    href="#"
+                                    class="btn btn-primary btn-block mb8"
+                                >
+                                    <i class="fa fa-wrench" />
+                                    Upgrade / Change ticket
+                                </a>
+                                <a
+                                    t-attf-href="/my/tickets/pdf/#{ticket.id}"
+                                    class="btn btn-secondary btn-block mb8"
+                                >
+                                <i class="fa fa-print" />
+                                    Print
+                                </a>
+                            </li>


Эти кнопки надо в одну колонку разместить, как в 14.-

em230418 and others added 3 commits October 18, 2024 10:18

[ADD] portal_event_tickets

b602dd3

Co-authored-by: Ivan Yelizariev <[email protected]> Co-authored-by: Alexandr Kolushov <[email protected]> Co-authored-by: Eugene Molotov <[email protected]> Co-authored-by: Victor Bykov <[email protected]> Co-authored-by: Ilmir Karamov <[email protected]>

[IMP] portal_event_tickets: добавил поле report_template_for_portal в…

edae9e8

…о вьюху

[IMP] portal_event_tickets: pre-commit auto fixes

a3b871b

azimkhankuat force-pushed the 17.0-mig-portal_event_tickets branch 2 times, most recently from 7bcd72d to 902baee Compare October 23, 2024 11:29

em230418 requested changes Oct 24, 2024

View reviewed changes

azimkhankuat force-pushed the 17.0-mig-portal_event_tickets branch 2 times, most recently from e5b6592 to 883bf20 Compare October 29, 2024 11:55

em230418 reviewed Oct 30, 2024

View reviewed changes

azimkhankuat force-pushed the 17.0-mig-portal_event_tickets branch from 883bf20 to 09bfa8a Compare October 30, 2024 11:24

[MIG] portal_event_tickets: Migration to 17.0

504d3bc

azimkhankuat force-pushed the 17.0-mig-portal_event_tickets branch from 09bfa8a to 504d3bc Compare October 30, 2024 11:58

em230418 approved these changes Oct 31, 2024

View reviewed changes

em230418 merged commit 2b0ab44 into it-projects-llc:17.0 Oct 31, 2024
4 checks passed

azimkhankuat deleted the 17.0-mig-portal_event_tickets branch November 8, 2024 04:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0] [MIG] portal_event_tickets #9

[17.0] [MIG] portal_event_tickets #9

azimkhankuat commented Oct 23, 2024

em230418 left a comment

em230418 Oct 24, 2024

azimkhankuat Oct 28, 2024

em230418 Oct 29, 2024

em230418 Oct 24, 2024

em230418 Oct 24, 2024

em230418 Oct 24, 2024

em230418 Oct 24, 2024

em230418 Oct 24, 2024

em230418 Oct 24, 2024

em230418 Oct 24, 2024

em230418 Oct 24, 2024

em230418 Oct 30, 2024

em230418 Oct 30, 2024

em230418 Oct 30, 2024

[17.0] [MIG] portal_event_tickets #9

[17.0] [MIG] portal_event_tickets #9

Conversation

azimkhankuat commented Oct 23, 2024

em230418 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment