17.0 mig website event attendee signup #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-By: Ivan Yelizariev <[email protected]> Co-authored-By: Artem Rafailov <[email protected]> Co-authored-By: Eugene Molotov <[email protected]> Co-authored-By: Victor Bykov <[email protected]>
em230418
requested changes
Oct 14, 2024
Comment on lines
9
to
10
| res = super().create(vals) | ||
| res = super().create(vals) | ||
|
|
There was a problem hiding this comment.
Два раза будут создаваться записи, когда надо один. Не годится.
Comment on lines
9
to
10
| super().setUp() | ||
| super().setUp() |
There was a problem hiding this comment.
Зачем тут два раза вызывать setUp?
Medeeet
force-pushed
the
17.0-mig-website_event_attendee_signup
branch
2 times, most recently
from
091cc30
to
1954813
Compare
em230418
requested changes
Oct 22, 2024
Comment on lines
8
to
10
| def create(self, vals): | ||
| res = super().create(vals) | ||
| res = super().create(vals) |
There was a problem hiding this comment.
Тут два раза создаем записи регистраций. Это неправильно.
Comment on lines
8
to
10
| def setUp(self): | ||
| super().setUp() | ||
| super().setUp() |
There was a problem hiding this comment.
Зачем тут два раза вызывать setUp?
Medeeet
force-pushed
the
17.0-mig-website_event_attendee_signup
branch
from
d752e38
to
55a6589
Compare
em230418
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.