Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 s3 decouple from spring oauth setup #159

Merged
merged 13 commits into from
Sep 19, 2024
Merged

Conversation

simonhir
Copy link
Member

@simonhir simonhir commented Sep 17, 2024

Description

Decouple s3-rest-client and s3-rest-service from Spring OAuth2 setup by removing default setup and adding it as example to the README.
Fixes coupling to specific scopes and naming.

@simonhir simonhir self-assigned this Sep 17, 2024
@simonhir simonhir marked this pull request as ready for review September 17, 2024 12:06
@simonhir simonhir requested a review from a team as a code owner September 17, 2024 12:06
@github-actions github-actions bot added Component: Integrations Issues regarding the Integrations Type: Bug The issue is a bug labels Sep 17, 2024
@simonhir simonhir marked this pull request as draft September 17, 2024 12:15
@simonhir simonhir force-pushed the bug/s3-rm-oauth-scopes branch from 8a1e1fe to 2781ecd Compare September 19, 2024 08:42
@simonhir simonhir changed the title 🔧 s3 rm unneeded oauth scope and username mapping 🔧 s3 decouple from spring oauth setup Sep 19, 2024
@simonhir simonhir force-pushed the bug/s3-rm-oauth-scopes branch from 2781ecd to d97da99 Compare September 19, 2024 08:59
@simonhir simonhir marked this pull request as ready for review September 19, 2024 09:01
@simonhir simonhir added the BREAKING Change may cause existing code to break label Sep 19, 2024
Copy link
Member

@devtobi devtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhir simonhir merged commit b11a06b into main Sep 19, 2024
11 checks passed
@simonhir simonhir deleted the bug/s3-rm-oauth-scopes branch September 19, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING Change may cause existing code to break Component: Integrations Issues regarding the Integrations Type: Bug The issue is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants