generated from it-at-m/oss-repository-en-template
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 s3 decouple from spring oauth setup #159
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Integrations
Issues regarding the Integrations
Type: Bug
The issue is a bug
labels
Sep 17, 2024
simonhir
force-pushed
the
bug/s3-rm-oauth-scopes
branch
from
September 19, 2024 08:42
8a1e1fe
to
2781ecd
Compare
simonhir
changed the title
🔧 s3 rm unneeded oauth scope and username mapping
🔧 s3 decouple from spring oauth setup
Sep 19, 2024
simonhir
force-pushed
the
bug/s3-rm-oauth-scopes
branch
from
September 19, 2024 08:59
2781ecd
to
d97da99
Compare
boal
requested changes
Sep 19, 2024
...-integration/refarch-email-integration-rest-example/src/main/resources/application-local.yml
Outdated
Show resolved
Hide resolved
...-integration/refarch-email-integration-rest-example/src/main/resources/application-local.yml
Outdated
Show resolved
Hide resolved
boal
requested changes
Sep 19, 2024
...-integration/refarch-email-integration-rest-example/src/main/resources/application-local.yml
Outdated
Show resolved
Hide resolved
boal
approved these changes
Sep 19, 2024
devtobi
reviewed
Sep 19, 2024
...-integration/refarch-email-integration-rest-example/src/main/resources/application-local.yml
Outdated
Show resolved
Hide resolved
devtobi
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
BREAKING
Change may cause existing code to break
Component: Integrations
Issues regarding the Integrations
Type: Bug
The issue is a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Decouple s3-rest-client and s3-rest-service from Spring OAuth2 setup by removing default setup and adding it as example to the README.
Fixes coupling to specific scopes and naming.