Revision Tag Support

[dgn]

Fixes #380

[codecov]

Codecov Report

Attention: Patch coverage is 85.91885% with 59 lines in your changes missing coverage. Please review.

Project coverage is 78.47%. Comparing base (cea83cc) to head (cf1384e).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...rs/istiorevisiontag/istiorevisiontag_controller.go	85.38%	36 Missing and 15 partials ⚠️
cmd/main.go	0.00%	6 Missing ⚠️
...trollers/istiorevision/istiorevision_controller.go	97.14%	1 Missing ⚠️
pkg/validation/namespace.go	87.50%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #413      +/-   ##
==========================================
+ Coverage   76.16%   78.47%   +2.31%     
==========================================
  Files          37       38       +1     
  Lines        1867     2272     +405     
==========================================
+ Hits         1422     1783     +361     
- Misses        371      400      +29     
- Partials       74       89      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[luksa]

You also need to add IstioRevisionTag to the PROJECT file. I believe some make target(s) only update certain files if the CRD is listed in the PROJECT file.

[nrfox]

nit: add enum validation for Istio and IstioRevision?

[nrfox]

Do you also need Istio here in cases where an Istio is referenced instead of an IstioRevision? In that case maybe this should be ,omitempty so you don't have a blank istioRevision when you reference and Istio.

[dgn]

no, actually the reasoning behind this field is exactly the fact that we could be referencing an Istio resource. The IstioRevision controller needs some easy way to know which IstioRevision is being referenced (even if technically it is referencing an Istio, it will always resolve to an IstioRevision), so instead of duplicating the resolution logic behind that, I'm just doing it at reconcile time in the IstioRevisionTag controller and write the result into this field