Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isso: config: Add support for environment variables in config #1037

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pkvach
Copy link
Contributor

@pkvach pkvach commented Sep 27, 2024

Checklist

  • All new and existing tests are passing
  • (If adding features:) I have added tests to cover my changes
  • (If docs changes needed:) I have updated the documentation accordingly.
  • I have added an entry to CHANGES.rst because this is a user-facing change or an important bugfix
  • I have written proper commit message(s)

What changes does this Pull Request introduce?

Adds support for using environment variables in the Isso configuration file (isso.cfg). Environment variables can be referenced using the $VAR_NAME or ${VAR_NAME} syntax.
This allows users to keep sensitive information, such as passwords, out of the configuration file itself by referencing environment variables.

  • Updated IssoParser to support environment variable substitution.
  • Enhanced documentation to include details on using environment variables in the configuration file.
  • Added unit tests to verify the functionality of environment variable substitution in IssoParser.

Why is this necessary?

Closes #397

@pkvach pkvach force-pushed the feat/config-env-var-support branch 2 times, most recently from 94443b7 to caaa1f5 Compare September 27, 2024 07:49
- Updated `IssoParser` to support environment variable substitution.
- Enhanced documentation to include details on using environment variables in the configuration file.
- Added unit tests to verify the functionality of environment variable substitution in `IssoParser`.

Closes isso-comments#397
@pkvach pkvach force-pushed the feat/config-env-var-support branch from caaa1f5 to 0ee2758 Compare October 2, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: Allow config parser to detect environment variables
1 participant