-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interrupt state #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! I added some small comments.
@@ -0,0 +1,33 @@ | |||
#pragma once | |||
|
|||
#include <TrajColl/CubicInterpolator.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unnecessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in f401697
} | ||
|
||
// Setup GUI | ||
ctl().gui()->addElement({ctl().name()}, mc_rtc::gui::Button("Start", [this]() { phase_ = 1; })); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "Resume" is a good name for the button in the Interrupt state. (and we can distinguishes the buttons between Initial state and Interrupt state)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in f401697
I want to stop executing multi-contact motion after finishing
MCC::ConfigMotion
state, butMCC::Initial
resets the managers and tasks in MultiContactController and they may cause inconsistency in the motion without interrupts.Therefore, I implemented
MCC::Interrupt
that only stops execution of multi-contact motion without reset.