Great job! #2
Open
Great job! #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I made a lot of changes.
As for me the most useful is to select text in textmate hit CMD-SHIFT-I and put it in yml file.
You always should you ya2yaml instead of to_yml because has better support for UTF-8 characters!
Next I did refactor of yours code and added possibility to edit translations according to token key.
Select a token and hit CMD-SHIFT-E will try to find an associated translation and give you a possibility to change :)
I also added a simple command that open bundle config.yml i TextMate.
I left only shortcut for inserting and editing because I has already bind to something else.
MyGenego should works but I'm really not using it so as for me is not usefull.
I had to change a token key from t('.my_token') to t('views.admin.users.new.my_token') cause that shortcut doesn't work even it is a symbol.
Please look through the code and give me a feedback!