Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2020 LaTeX+Word: support LBD with right citation in PDF/doc subject #23

Merged
merged 5 commits into from
Aug 20, 2020

Conversation

ChristianFrisson
Copy link
Contributor

@ChristianFrisson ChristianFrisson commented Aug 11, 2020

Hi @napulen and all,

This pull request adds the following changes:

Kind regards,
Christian (ISMIR 2020 LBD co-chair)

@ChristianFrisson ChristianFrisson changed the title 2020 LaTex+Word: support LBD with right citation in PDF/doc subject 2020 LaTeX+Word: support LBD with right citation in PDF/doc subject Aug 11, 2020
@napulen
Copy link
Member

napulen commented Aug 11, 2020

Hey Christian,

Since this is modifying the main tex and sty files, I think it should pass by the publication chairs before merging it into the repo.

A maybe faster solution would be to provide an independent template for this (e.g. lbd.tex and lbd.sty). I can merge that directly, although I like your approach more.

I'll forward this by email to the Publication chairs in case they're not watching PRs here.

I'll let you know how that goes.

Comment on lines 77 to 81
\RequirePackage{amsmath}
\RequirePackage{cite}
\RequirePackage{url}
\RequirePackage{graphicx}
\RequirePackage{color}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure, are they all required by ismir.sty? The ones that are not should probably stay in the .tex file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hyperref is now required in ismir.sty to fill PDF metadata (author, title, proceedings or extended abstract in subject) towards better indexation. I got used to load hyperref after most packages to avoid clashes.

@codaich
Copy link

codaich commented Aug 12, 2020

Thanks for this! I agree with @napulen that we should not merge any direct changes into the existing mainstream ISMIR paper templates. Speaking for myself, I would be happy with another branch for just the Late-Breaking Demos, or with entirely independent (and clearly separated and identified) documents included in the master branch (with a preference for the second option).

@ChristianFrisson
Copy link
Contributor Author

Hi @napulen and @codaich,

I have separated the LaTeX style file and template. Would the pull request be now ready for merging?

Kind regards,
Christian

Copy link
Member

@napulen napulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My only concern is with 2020/word/ISMIR2020_template.docx, which still shows changes after this PR. It should be identical to the one of the last commit. Any idea what are those changes?

@napulen
Copy link
Member

napulen commented Aug 18, 2020

Other than that, I'd merge this. Any thoughts @f0k @codaich?

@ChristianFrisson
Copy link
Contributor Author

Looks good. My only concern is with 2020/word/ISMIR2020_template.docx, which still shows changes after this PR. It should be identical to the one of the last commit. Any idea what are those changes?

I had added Proc. of the 21st Int. Society for Music Information Retrieval Conf., Montréal, Canada, 2020. as document subject, so that it exports as PDF subject in metadata, to improve indexation. Should I revert this file as well?

@napulen
Copy link
Member

napulen commented Aug 18, 2020

Hi @ChristianFrisson, that sounds like a legit contribution to the .docx file. In that case, I'd leave it as is and merge the change.

I'll wait for @codaich in case he has comments on this one.

Thanks!

@codaich
Copy link

codaich commented Aug 20, 2020

That sounds like a good addition, thanks. Yes, please do go ahead and merge.

@napulen napulen merged commit 8719b90 into ismir:master Aug 20, 2020
@napulen
Copy link
Member

napulen commented Aug 20, 2020

Done.

@ChristianFrisson
Copy link
Contributor Author

Thanks @napulen for the merge and related 2020v6 release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants